[oss-devel] [PATCH] fix audigy_digital_din (oss_sblive.c) for audigy2 cards

[Hannu Savolainen]

Hi Yair,

Massive thanks. This indeed seems to be a bug. Possibility of letting 
somebody to spot thi skind of ones was the main reason wy we open 
sourced OSS.

Best regards,

Hannu
--------
Yair K. wrote:
> Hi,
>
>   I found a possible bug in oss_sblive.c. SPDIF/OUT3 wasn't set on audigy2 cards, since the check only covered card_type == SB_AUDIGY. This change helped 'lash444' in a thread in the forums[1] to use analog output.
>
> [1] http://4front-tech.com/forum/viewtopic.php?t=2674
>
> diff -r 0d92a9bcdfad kernel/drv/oss_sblive/oss_sblive.c
> --- a/kernel/drv/oss_sblive/oss_sblive.c	Wed May 14 23:48:51 2008 +0300
> +++ b/kernel/drv/oss_sblive/oss_sblive.c	Sat May 17 01:48:05 2008 +0300
> @@ -2742,7 +2742,7 @@
>    /* switch the shared SPDIF/OUT3 to DIGITAL or ANALOG mode */
>    /* depending on whether the port is SPDIF or analog */
>  
> -  if (devc->card_type == SB_AUDIGY)
> +  if (devc->card_type & SB_AUDIGY)
>      {
>        reg = INL (devc->osdev, devc->base + 0x18) & ~A_IOCFG_GPOUT0;
>        val = (audigy_digital_din) ? 0x4 : 0;
> _______________________________________________
> oss-devel mailing list
> oss-devel at mailman.opensound.com
> http://mailman.opensound.com/mailman/listinfo/oss-devel
>