[oss-devel] ossxmix patch to ignore empty mixer groups

[Dev Mazumdar]

Clive Wright wrote:
> Zakhar Levchenko wrote:
>>
>>
>> Hi Clive,
>>
>> I've attached output of ossmix -D. Group 2 is definitely affected by 
>> your patch. As you can see group 3 follows this group and they have the 
>> same parent (0), so group 2 is ignored. On the other hand group 2 is the 
>> parent of such controls as ENVY24_RATE, ENVY24_SYNC etc.
>>
>> I also have attached my own patch to ossxmix that should ignore empty 
>> groups correctly. Could you please try it and see if it solves problems 
>> with empty groups and does not cause any other troubles? It works fine 
>> for me, that is all controls are shown, but I can't check if it ignores 
>> empty groups in practice (though theoretically it should).
>>
>> Regards,
>>            Zakhar Levchenko
> 
> Hi  Zakhar,
> 
> I haven't had chance to study the code in detail yet but it does solve 
> the problems with empty groups and does not appear to cause any other 
> troubles.
> 
> kind regards,
> 
> Clive
> 
> _______________________________________________
> oss-devel mailing list
> oss-devel at mailman.opensound.com
> http://mailman.opensound.com/mailman/listinfo/oss-devel
> 


Hi,


I think the problem is in the HDaudio driver - the create_group() calls 
are made if there are widgets or controls > 1. But no check is made to 
see if the widgets or controls are actually valid.

There should be a way to destroy an empty group so that the mixer applet 
doesn't have to do all kinds of stupid tricks trying to figure out if it 
should create a group or not.




regards
Dev


-- 
-----------------------------------------------------------
4Front Technologies
4035 Lafayette Place, Unit F, Culver City, CA 90232, USA.
Tel: (310) 202 8530		URL: www.opensound.com
Fax: (310) 202 0496 		Email: info at opensound.com
-----------------------------------------------------------