[oss-devel] ossxmix GangChange function

Clive Wright clive_wright at ntlworld.com
Thu Jan 17 20:30:03 EET 2008


Ganging MIXT_STEREOSLIDER16 controls in ossxmix causes left channel to 
go to full volume and right channel to be muted although this action is 
not apparent from inspection of the slider controls.

The problem is caused by the GangChange function using 8 bit shift and 
mask instead of 16 bits.

The attached patch corrects this error and provides two other changes:

1. The function returns without taking any action in the trivial case 
where (lval == rval).

2. The previous behaviour raised the channel with the lowest volume to 
that of the highest. In some circumstances this could cause annoyance.
The new behaviour sets both channels to a mean value.

regards,
Clive
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ossxmix.diff
Type: text/x-patch
Size: 1170 bytes
Desc: not available
Url : http://mailman.opensound.com/pipermail/oss-devel/attachments/20080117/f45cbf4b/attachment.bin 


More information about the oss-devel mailing list