[oss-devel] [PATCH] ossxmix - dynamically allocate arrays and other changes

[Yair K.]

On Monday 04 February 2008 22:49:18 Hannu Savolainen wrote:
> Hi,
>
> IMHO using dynamic allocation for tables that are just few kilobytes is
> overkill when the total size of ossxmix is in megabytes. It just makes
> the code unnecessarily complicated. So I would not like to accept this
> patch.
>
> However what you can do is to decrease MAX_DEVS to something like 16. In
> real world there will never be more than 16 mixers in OSS 4.0 systems.
>
> Best regards,
>
> Hannu

OK, but I'll still need to make a patch, because I didn't use MAX_DEVS 
correctly before - it is used both at variables such as root or set_counter 
(when the limit is the number of mixers in systems), and at variables like 
extnames (which should be a double array -  the limit is the number of mixers 
* number of controls), so it ended up very large to allow for the latter. Any 
idea for a good limit for the number of controls?

Yours,
	Yair K.