[oss-devel] [PATCH] ossxmix - dynamically allocate arrays and other changes

[Hannu Savolainen]

Hi,

IMHO using dynamic allocation for tables that are just few kilobytes is 
overkill when the total size of ossxmix is in megabytes. It just makes 
the code unnecessarily complicated. So I would not like to accept this 
patch.

However what you can do is to decrease MAX_DEVS to something like 16. In 
real world there will never be more than 16 mixers in OSS 4.0 systems.

Best regards,

Hannu
-------
Yair K. wrote:
> Hi,
>
>   This patch does three things:
>      1) Check the returned value in change_on_off, so the user can't 
> accidentally make a device's selected recording source not visible.
>      2) Make the device-dependant array dynamically allocated, to avoid 
> artificial limits or memory waste.
>      3) Set gtkvu initial level to 0, since this is closer to reality.
>
> Yours,
> 	Yair K.
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> oss-devel mailing list
> oss-devel at mailman.opensound.com
> http://mailman.opensound.com/mailman/listinfo/oss-devel
>