[oss-devel] [PATCH] savemixer changes

[Hannu Savolainen]

Hi Yair,

Many thanks for the changes. They will appear in the hg server soon.

In some systems /etc/oss is the OSS config directory instead of 
/usr/lib/oss/etc. It might be a good ideat to use /etc/oss if it exists.

Another useful change might be checking if the user is root (UID=0) or 
not. The default file name should be something like $HOME/.mixer.save 
for ordinary users (who cannot write to the OSS directory.

Best regards,

Hannu

Yair K. wrote:
> Hi,
>
>   The attached patch has some changes to savemixer:
>       1. Don't leak mixer fd.
>       2. Use getopt. Output usage when wrong switches are used.
>       3. Use default '/usr/lib/oss/etc' if reading /etc/oss.conf doesn't work.
>       4. Add '-f' option to specify different settings file instead 
> of '$OSSLIBDIR/etc/mixer.save' or '/etc/oss/mixer.save'.
>       5. Check existence of mixers in system before trying to load_config 
> when '-L' is used.
>       6. Update manpage (didn't mention /etc/oss/mixer.save though).
>       7. Various other changes (fgets doesn't need sizeof - 1, but can do with 
> sizeof, sprint -> snprintf, change message to point to ossdevlinks rather 
> than ossctl, etc.).
>
> Yours,
> 	Yair K.
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> oss-devel mailing list
> oss-devel at mailman.opensound.com
> http://mailman.opensound.com/mailman/listinfo/oss-devel
>