[oss-devel] [PATCH] ossplay - add time/gain display in verbose mode and others

[Hannu Savolainen]

Hi Yair,

Will be in the hg server soon.

I think we need to do more testing with the SYNC call. In theory calling 
SNDCTL_DSP_SYNC between files should be unnecessary if the sampe 
rate/format and #channels doesn't change. If that happens then 
setup_device() will close/reopen the device anyway. However for some 
reason this extra SYNC seems to be necessary (might be a bug in OSS).

I think the peak meter should be separated from -v. It may slow down the 
program too much when being run over slow network connection.

Maybe you should rename -l (loop) to -L and use -l for level display 
(like ossrecord does).

Btw, do you think you would be interested in implementing a GTK+ based 
audio player/recorder applet based on ossplay/decode.c? It looks like 
decode.c contains code that can be used both from ossplay and from the 
GTK+ version. This program doesn't meed to be able to record anything 
else than .WAV (and possibly .au to keep Sun happy). What do you think?

Best regards,

Hannu
-------
Yair K. wrote:
> Hi,
>
>   The attached patch does the following:
>      1. Add time/gain display in verbose mode (gain display code taken from 
> ossrecord).
>      2. Convert mu-law/A-law/other endians to standard formats (S16_NE, 
> S32_NE) when neccesary to do so for gain to work.
>      3. Don't call SNDCTL_DSP_SYNC at end of playing each file, since it 
> doesn't work well with loop mode when playing a single file and I didn't find 
> any problems with the line commented out.
>
>   The only negative I found is that when playing a particular file in verbose 
> mode,
> http://www.fileupyours.com/view/77985/a.wav
>   there's an annoying background noise (which doesn't exist in "regular" 
> playing), but I didn't manage to track the problem down.
>
> Yours,
> 	Yair K.
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> oss-devel mailing list
> oss-devel at mailman.opensound.com
> http://mailman.opensound.com/mailman/listinfo/oss-devel
>