[oss-devel] small misc fixes

[Hannu Savolainen]

Many thanks François,

I did these fixes in our source tree.

Best regards,

Hannu

François Revol written:
> Hi there, here are some simple fixes needed here:
> - fix the single C++ism (var decl after statement)
> - #define MIDI_DISABLED in oss_config.h, as it's not done unlike what 
> the online commented version says.
>   
This is defined in the v4.0 "stable" version. However the v4.1 "testing" 
version doesn't have it. The idea is that the MIDI code will be finished 
in the final v4.1 version.
> - get rid of error message from ulimit as not every platform dumps 
> core.
>
> There are other fixes needed for my platform beside specific code, but 
> they are more involved, biggest due to wrong assumptions about error 
> code sign due to incoherent standards. But I don't want to spoil 
> anything yet :)
>   
Hmm. Some explanation would be welcome.

> Btw, it could be useful to have a cvs/svn if possible.
>   
Our current plan is not to use any cvs/svn style systems. Instead we 
will produce ~weekly snapshots and use some kind of patch submission 
system (oss-devel list at this moment). However some kind of file server 
might be possible later.

There must be a way to inspect and approve the changes before they get 
in the official source tree. For the time being posting patches to this 
list looks the easiest approach.

> I suppose some platforms don't imply GNU make so caching `uname -m` 
> with a
> unamem=$(shell uname -m) in makefiles to speed it a little won't work.
>   
We have to support the native make commands under each platform so 
features not available in all of them cannot be used. In addition this 
kind of optimizations don't improve the compile speed that much.

Best regards,

Hannu