[oss-devel] bug in sblive.c

François Revol revol at free.fr
Wed Aug 29 20:27:15 EEST 2007


Hi,
it seems kernel/drv/sblive/sblive.c does a MUTEX_ENTER in attach_mpu, 
without disabling interrupts first.
After looking at other drivers, it seems the equivalent code if 
#ifdefed out by OBSOLETED_STUFF, and also don't require taking any 
spinlock anyway.
Should it be ifdefed out too ?
Should MUTEX_ENTER be removed or changed (then in other drivers too) ?

Btw, cmpci.c uses OBSOLETE_STUFF (no D) in #ifdef.

That's in 070717, and still in 070827.

François.



More information about the oss-devel mailing list