[oss-devel] Some fixes for 070717

François Revol revol at free.fr
Sat Aug 4 22:48:38 EEST 2007


Hi,
notwithstanding the BeOS port which I'll post about separately, here 
are some fixes for 070717:

* oss-v4.1test0-070717-misc-fixes.diff.txt:
- ossmix was doing a wrong cast to oss_mixext_root (the whole mixext 
instead of the data field). I was wondering why I didn't understand 
that part... :)
- corrected some typos and grammar as I went accross them,
- it seems the (really really broken IMO) Unixish habit of using 
negated return codes get people to use them negated when they shouldn't 
be (when comparing to errno)

* oss-v4.1test0-070717-atiaudio-fixes.diff.txt:
- I got random crashes (div by 0) with the ati driver, which seems to 
be caused by dmap->fragment_size being null, and I don't know the 
reason. Is it because of wrong ioctl call order ? I added a warning and 
continue like in another driver that had them already. I get those 
sometimes, but appart from filling my syslog it plays audio as well as 
when it doesn't happen. Any idea ?
- the last hunk appeared when diffing from the original tree, but I'm 
sure I didn't add it. Maybe it was in a previous version of the same 
revision (I downloaded it on both my computers and moved the tree 
around) ??? I suppose it can't hurt doing that check anyway.

François.



More information about the oss-devel mailing list